-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'RRIOT_F722' target #10714
base: master
Are you sure you want to change the base?
Add 'RRIOT_F722' target #10714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the changes to settings.json?
I have received the samples and will start the review soon. |
To track progress: RRIOT_F722
For reference: |
|
||
//******* FLASH ******** | ||
#define USE_FLASHFS | ||
#define USE_FLASH_W25Q128FV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be #define USE_FLASH_M25P16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking, looks like we haven't used this flash chip in inav yet.
You probably set it as recommended. I will have a look if I can enabled it with that driver, or if it needs its own driver.
#define UART6_RX_PIN PC7 | ||
#define UART6_TX_PIN PC6 | ||
|
||
#define SERIAL_PORT_COUNT 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 7.
VCP is included.
The build is failing due to warnings caused by wrong entries in target.h If you want to validate changes locallye, please run |
|
||
//DEF_TIM(TIM1, CH3, PA10, TIM_USE_CAMERA_CONTROL, 0, 0), | ||
|
||
DEF_TIM(TIM8, CH3, PC8, TIM_USE_OUTPUT_AUTO, 0, 0 ), // S1_OUT – D(2, 4, 7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motor order is wrong.
The first timer defined ends up as motor 1, second as motor 2, etc...
According to betaflight's configuration it should be:
#define MOTOR1_PIN PA9
#define MOTOR2_PIN PA8
#define MOTOR3_PIN PC9
#define MOTOR4_PIN PC8
#define MOTOR5_PIN PB5
#define MOTOR6_PIN PB4
No description provided.