Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'RRIOT_F722' target #10714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 'RRIOT_F722' target #10714

wants to merge 1 commit into from

Conversation

asteury
Copy link

@asteury asteury commented Feb 20, 2025

No description provided.

@mmosca mmosca added the New target This PR adds a new target label Feb 20, 2025
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the changes to settings.json?

@mmosca
Copy link
Collaborator

mmosca commented Feb 20, 2025

I have received the samples and will start the review soon.

@mmosca
Copy link
Collaborator

mmosca commented Feb 20, 2025

To track progress:

RRIOT_F722

  • Flash firmware
  • Calibrate accelerometer
  • Correct board orientation
  • Gyro working
  • Accelerometer working
  • Barometer working
  • Magnetometer working
  • Voltage sensor working
  • Correct voltage scale
  • Current sensor working (scale n/a, not AIO)
  • UART 1 working (rx plug)
  • UART 2 working (analog vtx plug)
  • UART 3 working (gps plug)
  • UART 4 working (hd vtx osd)
  • UART 5 working (ESC Telemetry)
  • UART 6 working (hd vtx sbus)
  • Video chain working Camera -> OSD - > VTX
  • LEDs working (no led pad)
  • S1-S4
    • DSHOT
    • Motor order
  • S5-S6
  • Blackbox (Flash)
  • Beeper working
  • PIN IO (pit switch)

For reference:

image

image


//******* FLASH ********
#define USE_FLASHFS
#define USE_FLASH_W25Q128FV
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be #define USE_FLASH_M25P16

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checking, looks like we haven't used this flash chip in inav yet.

You probably set it as recommended. I will have a look if I can enabled it with that driver, or if it needs its own driver.

#define UART6_RX_PIN PC7
#define UART6_TX_PIN PC6

#define SERIAL_PORT_COUNT 6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 7.

VCP is included.

@mmosca
Copy link
Collaborator

mmosca commented Feb 20, 2025

@asteury

The build is failing due to warnings caused by wrong entries in target.h

If you want to validate changes locallye, please run cmake -DWARNINGS_AS_ERRORS=ON to turn warnings as errors, like the github builds.


//DEF_TIM(TIM1, CH3, PA10, TIM_USE_CAMERA_CONTROL, 0, 0),

DEF_TIM(TIM8, CH3, PC8, TIM_USE_OUTPUT_AUTO, 0, 0 ), // S1_OUT – D(2, 4, 7)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motor order is wrong.

The first timer defined ends up as motor 1, second as motor 2, etc...

According to betaflight's configuration it should be:

#define MOTOR1_PIN PA9
#define MOTOR2_PIN PA8
#define MOTOR3_PIN PC9
#define MOTOR4_PIN PC8
#define MOTOR5_PIN PB5
#define MOTOR6_PIN PB4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New target This PR adds a new target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants