Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean ReplicateStatus unused methods #407

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+2 −36
Open

Clean ReplicateStatus unused methods #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4db9b5
Clean `ReplicateStatus` unused methods
mcornaton Apr 14, 2023
af02bfd
Merge branch 'develop' into feature/clean-replicate-status-unused-met…
mcornaton May 17, 2023
c9acc1b
Update CHANGELOG.md
mcornaton May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@ All notable changes to this project will be documented in this file.

## [[NEXT]](https://github.com/iExecBlockchainComputing/iexec-common/releases/tag/vNEXT) 2023

### Quality
### Quality
- Mark classes from `com.iexec.common.sdk.order`, `com.iexec.common.sdk.order.payload` and `com.iexec.common.chain.eip712` packages deprecated. (#414 #415)
- Clean `ReplicateStatus` unused methods. (#407)

## [[8.1.0]](https://github.com/iExecBlockchainComputing/iexec-common/releases/tag/v8.1.0) 2023-05-11

Expand Down
35 changes: 0 additions & 35 deletions src/main/java/com/iexec/common/replicate/ReplicateStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,26 +65,10 @@ public static boolean isSuccess(ReplicateStatus status) {
return getSuccessStatuses().contains(status);
}

public static boolean isFailure(ReplicateStatus status) {
return getFailureStatuses().contains(status);
}

public static boolean isFailedBeforeComputed(ReplicateStatus status) {
return status.ordinal() < COMPUTED.ordinal() && getFailureStatuses().contains(status);
}

public static boolean isCompletable(ReplicateStatus status) {
return getCompletableStatuses().contains(status);
}

public static boolean isFailable(ReplicateStatus status) {
return getFailableStatuses().contains(status);
}

public static boolean isAbortable(ReplicateStatus status) {
return getAbortableStatuses().contains(status);
}

public static boolean isRecoverable(ReplicateStatus status) {
return true; // just temporary
}
Expand Down Expand Up @@ -274,25 +258,6 @@ public static ChainContributionStatus getChainStatus(ReplicateStatus replicateSt
}
}

public static List<ReplicateStatus> getStatusesBeforeContributed() {
return Arrays.asList(
CREATED,
STARTING,
START_FAILED,
STARTED,
APP_DOWNLOADING,
APP_DOWNLOAD_FAILED,
APP_DOWNLOADED,
DATA_DOWNLOADING,
DATA_DOWNLOAD_FAILED,
DATA_DOWNLOADED,
COMPUTING,
COMPUTE_FAILED,
COMPUTED,
CONTRIBUTING,
CONTRIBUTE_FAILED);
}

public static List<ReplicateStatus> getMissingStatuses(ReplicateStatus from, ReplicateStatus to) {
List<ReplicateStatus> statuses = getSuccessStatuses();
if (!statuses.contains(from) || !statuses.contains(to)) {
Expand Down