Skip to content

perf(client): cache parsed chunk/batch origin coordinates #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RZDESIGN wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(client): cache parsed chunk/batch origin coordinates #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions client/src/chunks/Chunk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ export interface LightSource {
// Working variables
const vec3like: Vector3LikeMutable = { x: 0, y: 0, z: 0 };

// Caches for parsed string-ID → numeric-origin lookups.
// These are called in hot per-frame loops (view distance, sorting, culling).
// Each uncached call does split(',') + .map(Number) — 5 allocations per call.
const chunkOriginCache = new Map<ChunkId, Vector3Like>();
const batchOriginCache = new Map<BatchId, Vector3Like>();

export default class Chunk {
public readonly originCoordinate: Vector3Like;
private _chunkId: ChunkId;
Expand Down Expand Up @@ -44,8 +50,13 @@ export default class Chunk {
}

public static chunkIdToOriginCoordinate(chunkId: ChunkId): Vector3Like {
const [x, y, z] = chunkId.split(',').map(str => Number(str)) as [number, number, number];
return { x, y, z };
let cached = chunkOriginCache.get(chunkId);
if (!cached) {
const [x, y, z] = chunkId.split(',').map(str => Number(str)) as [number, number, number];
cached = { x, y, z };
chunkOriginCache.set(chunkId, cached);
}
return cached;
}

public static originCoordinateToChunkId(originCoordinate: Vector3Like): ChunkId {
Expand Down Expand Up @@ -89,8 +100,13 @@ export default class Chunk {
}

public static batchIdToBatchOrigin(batchId: BatchId): Vector3Like {
const [x, y, z] = batchId.split(',').map(str => Number(str)) as [number, number, number];
return { x, y, z };
let cached = batchOriginCache.get(batchId);
if (!cached) {
const [x, y, z] = batchId.split(',').map(str => Number(str)) as [number, number, number];
cached = { x, y, z };
batchOriginCache.set(batchId, cached);
}
return cached;
}

// Get all chunk IDs that belong to a batch (some may not exist in world)
Expand Down