Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyprbars: center button text #291

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

elviosak
Copy link
Contributor

@elviosak elviosak commented Feb 3, 2025

Some unicode characters didn't center properly, changing the width calculation to ink_rect fixes it, but it doesn't work for height too, so i kept logical_rect for height (same value from before, pango_layout_get_size gets values from the logical_rect).

before:
uncentered

after:
centered

i think i saw some issue about it but can't find it now, maybe it was some other issue and someone just left a comment about it.

edit: add pic if using ink_rect for height:
ink-height

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 6d525bc into hyprwm:main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants