Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unicode characters didn't center properly, changing the width calculation to ink_rect fixes it, but it doesn't work for height too, so i kept logical_rect for height (same value from before,
pango_layout_get_size
gets values from the logical_rect).before:
![uncentered](https://private-user-images.githubusercontent.com/33790211/409151989-0e6b94a9-884f-4360-abb3-5251427aa399.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDE4NjUsIm5iZiI6MTczOTAwMTU2NSwicGF0aCI6Ii8zMzc5MDIxMS80MDkxNTE5ODktMGU2Yjk0YTktODg0Zi00MzYwLWFiYjMtNTI1MTQyN2FhMzk5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA3NTkyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2YTBmYmFiODJiYjExZTk4YmM5NDExNTNhMDAwNDM3NGE1NzUwY2MzZjYxYWViZDY3ZjZkYjZmZTg3Y2JkOTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.B0iYBOn-r0xXyWJ8eSRkXOHfgqAxu-iFq8LoofLlANw)
after:
![centered](https://private-user-images.githubusercontent.com/33790211/409152027-2f98b23c-56e7-428b-a555-e9672ffba7f7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDE4NjUsIm5iZiI6MTczOTAwMTU2NSwicGF0aCI6Ii8zMzc5MDIxMS80MDkxNTIwMjctMmY5OGIyM2MtNTZlNy00MjhiLWE1NTUtZTk2NzJmZmJhN2Y3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA3NTkyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlMGVmNDhhOTBjNmUzNGJiMjljMWYxYjQxNDRjNmFlNmRjOTNkODJlMTk5NDc2OTdjY2NiYjVhNWEzODFjOGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8Gq3VYV8U3QjTwlbqRLSIiizvNhEolVthc9nA2GVas4)
i think i saw some issue about it but can't find it now, maybe it was some other issue and someone just left a comment about it.
edit: add pic if using ink_rect for height:
![ink-height](https://private-user-images.githubusercontent.com/33790211/409163818-a6fa74db-14f1-4fc9-ae8e-d1b47c6b0916.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDE4NjUsIm5iZiI6MTczOTAwMTU2NSwicGF0aCI6Ii8zMzc5MDIxMS80MDkxNjM4MTgtYTZmYTc0ZGItMTRmMS00ZmM5LWFlOGUtZDFiNDdjNmIwOTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDA3NTkyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk0MjdjNTNlNmEwN2NhNDlhMDZhZmVmZjJhNzU2N2QwNGJjODZjMWE2NjQ4N2ZhNDhhNzU1M2M3N2VkZmEzM2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.GUehulUlBBOR4rfzqEuQrZzSK7qOMCZ17wU7fiAACyc)