Improve and optimize timer FD logic#258
Conversation
Fixes increased timer latency, etc.
|
My pleasure! :3 I've also spotted another issue: |
|
@vaxerski Merging this without that fix will make the apparent problem worse. How should I proceed? |
|
I've done a v1 patch for the fix. Please let me know if it's correct and/or if I should change something. |
… function to be O(n) rather than O(n*n))
|
Little report here too, the recent changes have made 60fps very consistent and practically eliminated frameskip from sunshine streams too. However higher framerates like 144 still run consistently slower, all tools reporting about 143.6fps, and it gets a lot worse with older hardware, not even reaching 143fps. Frameskip is of course much less noticable at higher framerates, but missing a frame every 5 seconds is not ideal. So it's much better but could still be much better. |
|
I reckon the rest of the performance issues are related to polling time. Theoretically, all you'd need to do is to allow adjusting polling time for the fds and get the minimum between the default and the frame time. Practically, though, I'm trying to make this PR scoped on non-breaking changes. So I'll leave it at this for this PR, and do that for the rest. |
|
@vaxerski Ready to merge. |
|
we can do that in a followup |
|
Should I split prs tho? If the goal of this PR is optimizing timer related stuff, that's one of them. |
Fixes #206 (comment)
Supercedes #257