Skip to content

Conversation

@njdom24
Copy link
Contributor

@njdom24 njdom24 commented Oct 26, 2025

Describe your PR, what does it fix/add?

When screen-recording, DS constantly enables/disables between frames if the capture framerate is lower than the render framerate, causing frequent stutter (games) and modesets (VLC, non-shader CM). This change gives it some headroom before re-enabling DS.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Tested with games/VLC and capturing with gpu-screen-recorder w/ pipewire capture, and OBS.

Is it ready for merging, or does it need work?

Ready

@njdom24 njdom24 marked this pull request as draft October 26, 2025 07:26
@njdom24 njdom24 force-pushed the screencopy-ds-blocktime branch from 29dbec0 to b6a59b0 Compare October 26, 2025 07:33
@s0mebodyhelpme
Copy link

s0mebodyhelpme commented Oct 26, 2025

Idk what happened but applying these PRs (including this one) fixed the HDR screenshare being overly bright and having inaccurate colors for me.:
#12094
#12052
#12127
#12133
#12135

Only issue left is I can't adjust brightness or saturation anymore with sdrsaturation and sdrbrightness or with any of the luminance settings.

Note: I also updated my system recently but I doubt that's what caused it.

Edit: Nvm HDR games like Marvel's Spider-Man 2 still look overly bright. Indiana Jones works fine though.

@njdom24
Copy link
Contributor Author

njdom24 commented Oct 26, 2025

@s0mebodyhelpme Thanks for testing! #12094 would be the big one for the results you described. I'll have to give it another look to see why the SDR settings broke. I used sdr_max_luminance and it adjusted as expected, but I didn't test them all.

As for the screenshare brightness, I have some WIP changes locally to improve that, but I'd like to stop spamming changes and get the more significant stuff reviewed first.

@njdom24 njdom24 force-pushed the screencopy-ds-blocktime branch from b6a59b0 to 4c1a33f Compare October 26, 2025 17:57
@njdom24 njdom24 marked this pull request as ready for review October 26, 2025 18:00
@vaxerski vaxerski merged commit 17d0d69 into hyprwm:main Oct 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants