Fix content type for dynamic client registration#101
Open
ioweb-gr wants to merge 1 commit intohyprmcp:mainfrom
Open
Fix content type for dynamic client registration#101ioweb-gr wants to merge 1 commit intohyprmcp:mainfrom
ioweb-gr wants to merge 1 commit intohyprmcp:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the dynamic client registration HTTP response to ensure headers are set correctly before writing the status code, so clients reliably receive Content-Type: application/json on successful registration responses.
Changes:
- Set
Content-Typeheader before callingWriteHeader(http.StatusCreated)in the registration handler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor adjustment to the HTTP response handling in the
NewDynamicClientRegistrationHandlerfunction. The order of setting theContent-Typeheader and writing the status code is corrected to ensure proper HTTP response formatting.