This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
add init for config context, support legacy usage #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test and fixed docs
|
I reviewed this, looks good! Let's just clean up the readme portion to have two codeblocks with text above the codeblock for cleaner readme |
|
corrected, hope that makes sense |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add init for config context, support legacy usage
test and fixed docs
Posting this PR is for more clear error message when config is not properly initialized.
(There's not error message if config and registry're not set.)
And backward compitablity is supported, meaning the old way of setting config is still available but not recommended.