Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wasm filename should be last part of package name #754

Conversation

mattjohnsonpint
Copy link
Member

Description

In an AssemblyScript project, if the package name in package.json contains an org or other multiple parts, such as @foo/bar/baz then the wasm filename should just be the last part, ie. baz.

Fixes #751

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.
  • I have added or updated unit tests where appropriate, if applicable.

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner February 7, 2025 17:12
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) February 7, 2025 17:48
@mattjohnsonpint mattjohnsonpint merged commit 91b030b into main Feb 7, 2025
38 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-3018-wasm-build-not-resolved-when-package-name-includes branch February 7, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

WASM build not resolved when package name includes organization scope
2 participants