Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate modusdb instance by app #729

Merged

Conversation

mattjohnsonpint
Copy link
Member

Description

When we added ModusDB in v0.17.0, we didn't consider that multiple applications should not share the same database instance. Instead, we'll create a separate .modusdb in the project folder, and ensure it's in a .gitignore file so it doesn't get committed.

Checklist

All PRs should check the following boxes:

  • I have given this PR a title using the
    Conventional Commits syntax, leading with fix:,
    feat:, chore:, ci:, etc.
    • The title should also be used for the commit message when the PR is squashed and merged.
  • I have formatted and linted my code with Trunk, per the instructions in
    the contributing guide.

If the PR includes a code change, then also check the following boxes. (If not, then delete the
next section.)

  • I have added an entry to the CHANGELOG.md file.
    • Add to the "UNRELEASED" section at the top of the file, creating one if it doesn't yet exist.
    • Be sure to include the link to this PR, and please sort the section numerically by PR number.
  • I have manually tested the new or modified code, and it appears to behave correctly.
  • I have added or updated unit tests where appropriate, if applicable.

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner January 25, 2025 01:16
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) January 25, 2025 01:16
@mattjohnsonpint mattjohnsonpint merged commit 4aced09 into main Jan 25, 2025
54 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2980-separate-local-modusdb-instance-per-project branch January 25, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants