Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update runtime wasm tests #661

Merged
merged 7 commits into from
Dec 21, 2024

Conversation

mattjohnsonpint
Copy link
Member

Description

The language-specific tests in the runtime rely on pre-built wasm files, which haven't been updated recently. Upon update I found and fixed a few issues:

  • The change made in fix: unused imports should not be included in metadata #657 was filtering slices needed for map subtypes
  • The runtime was missing a return statement in the case of an invalid execution plan error
  • The host functions used in the tests needed a modus_ prefix in the module name, to be picked up by the extractor in the Modus Go SDK
  • Go no longer allows int in wasm imports, so host functions need to use int32 (or int64)

I also added some more VS Code debug profiles to troubleshoot test app build failures.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner December 21, 2024 02:47
@mattjohnsonpint mattjohnsonpint enabled auto-merge (squash) December 21, 2024 02:52
@mattjohnsonpint mattjohnsonpint merged commit 157122e into main Dec 21, 2024
62 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2784-update-runtime-wasm-tests branch December 21, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants