Added get multiple api for badger #2173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested changes
Feb 18, 2025
db.go
Outdated
| @@ -736,6 +736,8 @@ func (db *DB) getMemTables() ([]*memTable, func()) { | |||
| // get returns the value in memtable or disk for given key. | |||
| // Note that value will include meta byte. | |||
| // | |||
| // getBatch would return the values of list of keys in order | |||
There was a problem hiding this comment.
The first word of the comment must be the same name as the function, same for get as well
db.go
Outdated
| @@ -747,7 +749,54 @@ func (db *DB) getMemTables() ([]*memTable, func()) { | |||
| // do that. For every get("fooX") call where X is the version, we will search | |||
| // for "fooX" in all the levels of the LSM tree. This is expensive but it | |||
| // removes the overhead of handling move keys completely. | |||
| func (db *DB) getBatch(keys [][]byte, keysRead []bool) ([]y.ValueStruct, error) { | |||
| if db.IsClosed() { | |||
| return []y.ValueStruct{}, ErrDBClosed | |||
There was a problem hiding this comment.
can this not be nil, ErrDBClosed?
db.go
Outdated
| if keysRead[j] { | ||
| continue | ||
| } | ||
| version := y.ParseTs(key) |
There was a problem hiding this comment.
this can be an argument to the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.