Skip to content

Fix comments in basic agent example #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Fix comments in basic agent example #128

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4fa25f
Change != to == in basic agent example
Feb 8, 2025
1b61b9f
Fix bug: use extra_agent_exchange instead of agent_exchange
Feb 8, 2025
6c5277c
Change docs & variable name to make more clear
Feb 8, 2025
c7113ae
Another attempt at better docs
Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/basic_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ def main():
# Set up the environment (exchange, account info, etc.) for testing purposes.
address, info, exchange = example_utils.setup(constants.TESTNET_API_URL, skip_ws=True)

# Ensure that the wallet address and agent address are not the same
# This prevents the risk of accidentally creating an agent using the wallet itself.
if exchange.account_address != exchange.wallet.address:
# Ensure that the wallet address and account address are the same.
# If these are not the same then an agent will be approved for the wallet address instead of the account address, and the order will fail.
if address != exchange.wallet.address:
raise Exception("You should not create an agent using an agent")

approve_result, agent_key = exchange.approve_agent()
Expand Down Expand Up @@ -73,8 +73,8 @@ def main():
print("Running with extra agent address:", extra_agent_account.address)

# Place an order with the extra agent using the same process as the original agent.
print("Placing order with original agent")
order_result = agent_exchange.order("ETH", True, 0.2, 1000, {"limit": {"tif": "Gtc"}})
print("Placing order with extra agent")
order_result = extra_agent_exchange.order("ETH", True, 0.2, 1000, {"limit": {"tif": "Gtc"}})
print(order_result)

# If the extra agent's order is placed successfully, attempt to cancel it.
Expand Down