Restrict restoring sandboxes to snapshot taken on self #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
force-pushed
the
restrict_snapshots
branch
from
f857c5d to
acef3b9
Compare
…ndbox Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
restrict_snapshots
branch
from
acef3b9 to
23309b8
Compare
simongdavies
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #742
This PR makes sure sandboxes can only be restored to snapshots taken on the same sandbox. This restriction is currently needed because could cause corrupt state otherwise. We will eventually lift this restriction.
If you worry that the u64 will overflow, don't 😎