-
Notifications
You must be signed in to change notification settings - Fork 143
Conversation
Seems like this upgrade is blocked by rust-num/num-bigint#128 for now. It is needed to upgrade the version of num-bigint from |
|
The |
The |
There’s already a PR that needs to be merged that fixes the asm build error |
So I think it is possible to merge this PR after the fix for the |
Most likely. For now, I don't foresee any problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved provided we merge PR 123 first
Upgrade from 1.0.0-pre.2 to .0.0-pre.3 And corresponding fixes for other lib versions and src files Signed-off-by: Egor Ivkov <[email protected]>
Description of changes
Upgrade from 1.0.0-pre.2 to 1.0.0-pre.3
And corresponding fixes for other lib versions and src files
Benefits
There is an issue with the usage of latest ursa (0.3.2) with latest libp2p(0.16.2): they have incompatible versions of ed25519-dalek (ursa - 1.0.0-pre.2 and libp2p - 1.0.0-pre.3). It could be solved only by downgrading libp2p to version 0.13.1 which is rather old now.
Therefore this PR is meant to fix that and make latest ursa and libp2p compatible, as they have rather intersecting user groups in my opinion.
Signed-off-by: Egor Ivkov [email protected]