Skip to content
This repository was archived by the owner on Mar 11, 2024. It is now read-only.

Upgrades version of ed25519-dalek #104

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

e-ivkov
Copy link
Contributor

@e-ivkov e-ivkov commented Mar 18, 2020

Description of changes

Upgrade from 1.0.0-pre.2 to 1.0.0-pre.3
And corresponding fixes for other lib versions and src files

Benefits

There is an issue with the usage of latest ursa (0.3.2) with latest libp2p(0.16.2): they have incompatible versions of ed25519-dalek (ursa - 1.0.0-pre.2 and libp2p - 1.0.0-pre.3). It could be solved only by downgrading libp2p to version 0.13.1 which is rather old now.

Therefore this PR is meant to fix that and make latest ursa and libp2p compatible, as they have rather intersecting user groups in my opinion.

Signed-off-by: Egor Ivkov [email protected]

@e-ivkov e-ivkov changed the title Upgrades version of ed25519-dalek WIP: Upgrades version of ed25519-dalek Mar 18, 2020
@e-ivkov
Copy link
Contributor Author

e-ivkov commented Mar 19, 2020

Seems like this upgrade is blocked by rust-num/num-bigint#128 for now. It is needed to upgrade the version of num-bigint from 0.2 to 0.3.

@mikelodder7
Copy link
Contributor

Seems like this upgrade is blocked by rust-num/num-bigint#128 for now. It is needed to upgrade the version of num-bigint from 0.2 to 0.3.

num-bigint 0.3 hasn't been released. The highest it goes is 0.2.6 and that version is still tied to 0.5. I'm tempted to push my own crate that does work so this can be unblocked. I also need to update glass_pumpkin but have been stuck on this version as well. Perhaps I'll do that later today.

@e-ivkov e-ivkov changed the title WIP: Upgrades version of ed25519-dalek Upgrades version of ed25519-dalek Jun 19, 2020
@e-ivkov
Copy link
Contributor Author

e-ivkov commented Jun 19, 2020

The 0.3 version of num-bigint was released on 12th of June. So hopefully we can also upgrade the versions here.

@e-ivkov
Copy link
Contributor Author

e-ivkov commented Jun 19, 2020

The asm build target seems to also fail on previous master branch commits with the same error: error: the legacy LLVM-style asm! syntax is no longer supported. So I guess this PR does not introduce new problems for asm.

@mikelodder7
Copy link
Contributor

There’s already a PR that needs to be merged that fixes the asm build error

@e-ivkov
Copy link
Contributor Author

e-ivkov commented Jun 19, 2020

There’s already a PR that needs to be merged that fixes the asm build error

So I think it is possible to merge this PR after the fix for the asm will be merged?

@mikelodder7
Copy link
Contributor

Most likely. For now, I don't foresee any problem.

Copy link
Contributor

@mikelodder7 mikelodder7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved provided we merge PR 123 first

Upgrade from 1.0.0-pre.2 to .0.0-pre.3
And corresponding fixes for other lib versions and src files

Signed-off-by: Egor Ivkov <[email protected]>
@brentzundel brentzundel merged commit 7e8ba24 into hyperledger-archives:master Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants