chore: box Status contents (#2253) #2282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 20, 2025
tonic/src/status.rs
Outdated
| pub struct Status { | ||
| pub struct Status(Box<StatusInner>); | ||
|
|
||
| impl From<StatusInner> for Status { |
There was a problem hiding this comment.
This was marginally more ergonomic than creating a constructor, but let me know if you would prefer a constructor instead
There was a problem hiding this comment.
I think we need to make this a private function on status so that it doesn't show up in the docs? I don't want the docs to even reference StatusInner at all.
There was a problem hiding this comment.
Good point, although #[doc(hidden)] would also work
LucioFranco
requested changes
May 21, 2025
tonic/src/status.rs
Outdated
| pub struct Status { | ||
| pub struct Status(Box<StatusInner>); | ||
|
|
||
| impl From<StatusInner> for Status { |
There was a problem hiding this comment.
I think we need to make this a private function on status so that it doesn't show up in the docs? I don't want the docs to even reference StatusInner at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #2253
Solution