refactor(server): Add explicit lifetime annotations for Handler trait #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be totally fine, especially since it seems you can elide these lifetimes on implementations with no problem. |
|
I wonder if this is an example of rust-lang/rfcs#738 ? |
|
I had the same thought - I'm pretty sure it is, but I'm not certain. I'm not really sure exactly what it is an example of, but its certainly related. |
|
Anyway I think this is good to go, since the lifetimes are actually always the same. |
reem
added a commit
that referenced
this pull request
Jan 27, 2015
refactor(server): Add explicit lifetime annotations for Handler trait
|
Oh wow, thank you so much for adding this. |
|
@flubba86 don't keep those issues to yourself! We wanna fix em. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's different from the elided lifetimes, but having at least one explicit shared lifetime has allowed me to actually get the compiler to trust me on some dependent code.
Any concerns on this being too restrictive?