Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Jan 9, 2026

Closes HDX-3180

Summary

This PR makes a couple of changes to TimeChart axis bounds

  1. Y Axis lower bound is now always 0 unless a series is selected (partial revert of feat: Add chart legend series filtering #1572)
  2. X-Axis bounds have been adjusted so that
    1. There is no longer an empty partial interval's worth of space at the end of line charts
    2. The first bar of a bar chart no longer overlaps with the Y Axis

Before

  • The first Bar in bar charts overlaps the Y Axis
Screenshot 2026-01-09 at 2 55 27 PM
  • There is an empty partial (or full) interval at the end of charts
Screenshot 2026-01-09 at 2 55 21 PM
  • Y Axis lower bound is non-zero when no series are selected
Screenshot 2026-01-09 at 2 38 54 PM Screenshot 2026-01-09 at 2 37 26 PM

After

  • Bars fit fully within the chart domain
Screenshot 2026-01-09 at 2 55 42 PM
  • There is no empty space at the end of the line charts
  • Y Axis lower bound is always 0 when no series are selected
Screenshot 2026-01-09 at 2 55 50 PM

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

🦋 Changeset detected

Latest commit: 35cb617

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 9, 2026 8:28pm

@claude
Copy link

claude bot commented Jan 9, 2026

Code Review

No critical issues found.

The changes properly fix chart axis bounds with clean implementation:

Strengths:

  • Y-axis now defaults to 0 (better UX for most time-series charts)
  • X-axis domain calculation correctly handles bar chart padding
  • Proper use of isSameSecond and date-fns utilities
  • New required props passed from sole caller (DBTimeChart.tsx)
  • Changeset file included

Minor observations:

  • dateRangeEndInclusive defaults to true in MemoChart signature but is set to false in convertToTimeChartConfig - ensure this is intentional behavior
  • Consider adding JSDoc comment to explain the half-granularity padding logic for bar charts (lines 597-603)

Changes are well-contained and safe to merge.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

E2E Test Results

All tests passed • 59 passed • 4 skipped • 864s

Status Count
✅ Passed 59
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew requested review from a team and knudtty and removed request for a team January 9, 2026 20:44
Copy link
Member

@brandon-pereira brandon-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty!

@kodiakhq kodiakhq bot merged commit 1e6987e into main Jan 9, 2026
14 checks passed
@kodiakhq kodiakhq bot deleted the drew/axis-bounds branch January 9, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants