Skip to content

fix: Fix missing dashboard edit icons on search tile #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Jan 9, 2026
Merged

fix: Fix missing dashboard edit icons on search tile #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cold-seas-allow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix: Fix missing dashboard edit icons on search tile
55 changes: 31 additions & 24 deletions packages/app/src/DBDashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ import {
useDeleteDashboard,
} from '@/dashboard';

import ChartContainer from './components/charts/ChartContainer';
import DBSqlRowTableWithSideBar from './components/DBSqlRowTableWithSidebar';
import OnboardingModal from './components/OnboardingModal';
import { Tags } from './components/Tags';
Expand Down Expand Up @@ -394,30 +395,36 @@ const Tile = forwardRef(
/>
)}
{queriedConfig?.displayType === DisplayType.Search && (
<DBSqlRowTableWithSideBar
enabled
sourceId={chart.config.source}
config={{
...queriedConfig,
orderBy: [
{
ordering: 'DESC',
valueExpression: getFirstTimestampValueExpression(
queriedConfig.timestampValueExpression,
),
},
],
dateRange,
select:
queriedConfig.select ||
source?.defaultTableSelectExpression ||
'',
groupBy: undefined,
granularity: undefined,
}}
isLive={false}
queryKeyPrefix={'search'}
/>
<ChartContainer
title={title}
toolbarItems={[hoverToolbar]}
disableReactiveContainer
>
<DBSqlRowTableWithSideBar
enabled
sourceId={chart.config.source}
config={{
...queriedConfig,
orderBy: [
{
ordering: 'DESC',
valueExpression: getFirstTimestampValueExpression(
queriedConfig.timestampValueExpression,
),
},
],
dateRange,
select:
queriedConfig.select ||
source?.defaultTableSelectExpression ||
'',
groupBy: undefined,
granularity: undefined,
}}
isLive={false}
queryKeyPrefix={'search'}
/>
</ChartContainer>
)}
</ErrorBoundary>
</div>
Expand Down
Loading