Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Jan 8, 2026

Summary

This PR fixes:

  1. Dashboard tile buttons wrapping due to long titles
  2. ClickHouse dashboard subtitles rendering inline

Before

Screenshot 2026-01-08 at 3 47 29 PM Screenshot 2026-01-08 at 3 47 22 PM Screenshot 2026-01-08 at 3 47 17 PM

After

Screenshot 2026-01-08 at 3 46 15 PM Screenshot 2026-01-08 at 3 46 22 PM Screenshot 2026-01-08 at 3 46 40 PM Screenshot 2026-01-08 at 3 46 33 PM

@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

🦋 Changeset detected

Latest commit: e67d78d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 8, 2026 8:53pm

@claude
Copy link

claude bot commented Jan 8, 2026

PR Review - Visual Bug Fixes

No critical issues found.

The changes properly fix the visual layout issues:

Working correctly:

  • ✅ ChartContainer: wrap="nowrap" prevents toolbar button wrapping, proper flex sizing prevents title overflow
  • ✅ DBDashboardPage: visibility: hidden approach maintains layout space (prevents reflow), better than conditional render
  • ✅ DisplaySwitcher: wrap="nowrap" prevents button wrapping
  • ✅ ClickhousePage: Stack gap={0} properly stacks subtitle text (replaces Fragment)

All changes are UI-only with appropriate Mantine component usage following established patterns.

@pulpdrew pulpdrew force-pushed the drew/chart-container-fixes branch from a6a0d41 to e67d78d Compare January 8, 2026 20:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

E2E Test Results

1 test failed • 57 passed • 4 skipped • 768s

Status Count
✅ Passed 57
❌ Failed 1
⚠️ Flaky 2
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

gap="0px"
onMouseDown={e => e.stopPropagation()}
key="hover-toolbar"
style={{ visibility: hovered ? 'visible' : 'hidden' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually hiding this instead of conditionally rendering it, so that the title and tile layout doesn't shift when hovering on the tile.

Copy link
Member

@brandon-pereira brandon-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kodiakhq kodiakhq bot merged commit 8172fba into main Jan 8, 2026
21 of 24 checks passed
@kodiakhq kodiakhq bot deleted the drew/chart-container-fixes branch January 8, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants