-
Notifications
You must be signed in to change notification settings - Fork 349
fix: Fix a couple of visual bugs in Chart titles #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e67d78d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review - Visual Bug Fixes✅ No critical issues found. The changes properly fix the visual layout issues: Working correctly:
All changes are UI-only with appropriate Mantine component usage following established patterns. |
a6a0d41 to
e67d78d
Compare
E2E Test Results❌ 1 test failed • 57 passed • 4 skipped • 768s
Tests ran across 4 shards in parallel. |
| gap="0px" | ||
| onMouseDown={e => e.stopPropagation()} | ||
| key="hover-toolbar" | ||
| style={{ visibility: hovered ? 'visible' : 'hidden' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually hiding this instead of conditionally rendering it, so that the title and tile layout doesn't shift when hovering on the tile.
brandon-pereira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary
This PR fixes:
Before
After