Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Jan 6, 2026

Summary

This PR adds MV configurations to the play environment, and backports a materialized view fix from EE to this repo.

Screenshot 2026-01-06 at 3 03 06 PM Screenshot 2026-01-06 at 3 05 43 PM Screenshot 2026-01-06 at 3 03 05 PM

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

⚠️ No Changeset found

Latest commit: 7a473ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 7, 2026 5:12pm

@claude
Copy link

claude bot commented Jan 6, 2026

PR Review

✅ No critical issues found.

Minor observations:

  • ⚠️ Potential edge case: In SearchTotalCountChart.tsx:23, filterColumnMetaByType(meta, [JSDataType.Number])?.[0] could return undefined if no numeric columns exist → Consider adding validation or fallback
  • 📝 The materialized views config is duplicated between .env.e2e and OnboardingModal.tsx → Consider extracting to shared constant if these drift often

The fix correctly handles dynamic column names from materialized views and follows existing patterns in the codebase (similar usage in ChartUtils.tsx).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

E2E Test Results

All tests passed • 56 passed • 4 skipped • 715s

Status Count
✅ Passed 56
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew marked this pull request as ready for review January 6, 2026 20:25
@pulpdrew pulpdrew requested review from a team and brandon-pereira and removed request for a team January 7, 2026 12:38
Copy link
Member

@brandon-pereira brandon-pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wicked! 🐎

@kodiakhq kodiakhq bot merged commit e9eb84e into main Jan 7, 2026
12 checks passed
@kodiakhq kodiakhq bot deleted the drew/play-mvs branch January 7, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants