-
Notifications
You must be signed in to change notification settings - Fork 349
feat(app): refactor Sources components and add custom Mantine UI variants #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ec4a48a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. Minor suggestions (optional):
Overall, this is a solid refactor that improves code organization and establishes a consistent UI pattern going forward. The custom Mantine variants are well-implemented and the component extraction makes the Sources functionality more reusable. |
E2E Test Results✅ All tests passed • 56 passed • 4 skipped • 725s
Tests ran across 4 shards in parallel. |
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor comments on a storybook, but overall looks great!
Co-authored-by: Drew Davis <[email protected]>
…or improved organization and clarity
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
In preparation for the new onboarding flow, this PR reorganizes source management components into a dedicated
Sources/folder, introduces a consistent custom button/action icon variant system, and improves the Storybook development environment.Changes
🗂️ Sources Component Refactoring
index.ts) for cleaner importsSourceForm(there were some complaints before about the position of these buttons)OnboardingModal.tsx,DBSearchPage.tsx, andTeamPage.tsx🎨 Custom Mantine UI Variants
Add primary, secondary, and danger button/action icon variants in
mantineTheme.ts:primarysecondarydangerUpdated components:
ConfirmDeleteMenu,ErrorBoundary,SourceForm📚 Improve Storybook with font switching and component stories
react-queryto@tanstack/react-queryin previewnext/routerwebpack alias for component stories🔧 Update ErrorBoundary styling with danger variant
IconExclamationCirclevariant="danger"for retry buttonTesting
yarn app:storybookScreenshots
As you can see the buttons are now positioned on bottom

We should from now on, only use these buttons variants

primary | secondary | dangerThe SourcesList is now a component. Why? It might be used in the new onboarding flow.
