Skip to content

cleanup test-e2e additional flags so they're easier to add #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jan 4, 2026
Merged

cleanup test-e2e additional flags so they're easier to add #1543

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
786b1cf
cleanup test-e2e additional flags so they're easier to add
brandon-pereira Dec 31, 2025
64fd6ca
pr feedback
brandon-pereira Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions scripts/test-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,7 @@ wait_for_mongodb() {
run_local_mode() {
echo "Running E2E tests in local mode (frontend only)..."
cd "$REPO_ROOT/packages/app"
if [ -n "$TAGS" ]; then
yarn test:e2e --local --grep "$TAGS" ${UI_MODE:+--ui}
else
yarn test:e2e --local ${UI_MODE:+--ui}
fi
yarn test:e2e --local $ADDITIONAL_FLAGS
}

run_fullstack_mode() {
Expand All @@ -122,13 +118,18 @@ run_fullstack_mode() {

# Run tests in full-stack mode (default for yarn test:e2e)
cd "$REPO_ROOT/packages/app"
if [ -n "$TAGS" ]; then
yarn test:e2e --grep "$TAGS" ${UI_MODE:+--ui}
else
yarn test:e2e ${UI_MODE:+--ui}
fi
yarn test:e2e $ADDITIONAL_FLAGS
}

# Build additional flags
ADDITIONAL_FLAGS=""
if [ -n "$TAGS" ]; then
ADDITIONAL_FLAGS="--grep $TAGS"
fi
if [ "$UI_MODE" = true ]; then
ADDITIONAL_FLAGS="$ADDITIONAL_FLAGS --ui"
fi

# Main execution
if [ "$LOCAL_MODE" = true ]; then
run_local_mode
Copy link
Member

@wrn14897 wrn14897 Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: what do you think about moving all these flags before the function defs? imo its easier to follow

Copy link
Member Author

@brandon-pereira brandon-pereira Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrn14897 good idea, updated!

Expand Down
Loading