-
Notifications
You must be signed in to change notification settings - Fork 348
feat: Align date ranges to chart and MV granularity (Line/Bar charts) #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4fd206b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code ReviewCritical Issues
Important Issues
Quality Issues
Non-Blocking
Recommendation: Fix offset calculation bug before merge |
E2E Test Results✅ All tests passed • 56 passed • 4 skipped • 710s
Tests ran across 4 shards in parallel. |
b69c64c to
251f167
Compare
251f167 to
986d465
Compare
knudtty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long awaited! Great fix
Closes HDX-3067
Closes #1331
Closes #1212
Closes #1468
Summary
This PR makes a number of improvements around the way we handle date ranges and granularities, in an effort to minimize discrepancies between aggregate values queried from original data and aggregate values queried from materialized views.
Demo
Show Complete Intervals Option
Screen.Recording.2025-12-29.at.3.20.59.PM.mov