Fix CMake testing issues #1736
Open
Fix CMake testing issues #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. include(CTest) will set BUILD_TESTING=1 if it isn't already set, so only include CTest conditionally. 2. Update instructions to account for missing CMAKE_OSX_SYSROOT
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
- Coverage 88.48% 88.47% -0.02%
==========================================
Files 383 383
Lines 31781 31781
==========================================
- Hits 28122 28118 -4
- Misses 3659 3663 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include(CTest) will set BUILD_TESTING=1 if it isn't already set, so only include CTest conditionally.
Update instructions to account for missing CMAKE_OSX_SYSROOT