Emitter DSL #1669
Merged
Emitter DSL #1669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
- Coverage 88.36% 85.82% -2.54%
==========================================
Files 382 383 +1
Lines 31585 32749 +1164
==========================================
+ Hits 27910 28107 +197
- Misses 3675 4642 +967 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dabrahams
force-pushed
the
emitter-dsl
branch
3 times, most recently
from
9f04d41 to
14fc863
Compare
dabrahams
force-pushed
the
emitter-dsl
branch
2 times, most recently
from
c0f3c66 to
e396985
Compare
Thanks @kyouku-taiga!
This reverts commit 4ac0fcd.
dabrahams
force-pushed
the
emitter-dsl
branch
4 times, most recently
from
4b877c0 to
efd04ad
Compare
dabrahams
added a commit
that referenced
this pull request
May 16, 2025
dabrahams
added a commit
that referenced
this pull request
May 19, 2025
Revert "Emitter DSL/refactoring, phase 1 (#1669)" I broke the build; I will have to proceed more cautiously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kyouko-taiga PTAL to make sure you think this is on the right track. Obviously comments are outdated, etc and the whole thing is WIP