Skip to content

Initialize Optional member in Future initializer. #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lucteo
Copy link
Contributor

@lucteo lucteo commented Jan 10, 2024

No description provided.

@lucteo lucteo requested a review from kyouko-taiga January 10, 2024 20:33
Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR titles says it's about initializing an optional, but the changes are about an implementation of concurrent sort. I'm happy to review that code but is it really the PR you wanted to submit?

@kyouko-taiga
Copy link
Contributor

Also note that the problem about the initialization of Future's member is addressed by #1313.

@dabrahams
Copy link
Collaborator

@lucteo please either answer @kyouko-taiga's question and get this PR moving forward, or close it. Thanks.

@lucteo lucteo closed this May 10, 2025
@lucteo lucteo deleted the future_initialization branch May 10, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants