Get rid of FunctionType.parameterCount. - #142
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 84.96% 84.69% -0.28%
==========================================
Files 57 59 +2
Lines 1417 1457 +40
==========================================
+ Hits 1204 1234 +30
- Misses 213 223 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks for the work! I think my version is simpler - we don't need to actually read the whole array, as we can query individual elements through the C++ API: #141 |
|
Yours is much better; I couldn't find the function that just gets one parameter or I wouldn't have done all that. Mine doesn't use any lazy properties. Make yours RandomAccess though |
|
Oh wow, it was so late yesterday that I somehow misread |
I will proceed with documentation and any necessary tests if we believe this is worth the added complexity.