Improve testing of hy2py #1547
Merged
Improve testing of hy2py #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodiologist
force-pushed
the
hy2py-testing
branch
5 times, most recently
from
30903a5 to
432e81f
Compare
vodik
reviewed
Mar 28, 2018
| import importlib.util | ||
| spec = importlib.util.spec_from_file_location(name, path) | ||
| m = importlib.util.module_from_spec(spec) | ||
| spec.loader.exec_module(m) |
There was a problem hiding this comment.
This works on PY35 as well, for what its worth. spec_from_file_location came with 3.4 and module_from_spec with 3.5
There was a problem hiding this comment.
I tried enabling this for Python 3.5 and I got a weird crash inside pytest, so I've changed it back.
There was a problem hiding this comment.
Yeah, probably won't work until #1518 is in. I tested it there. We don't implement the importlib APIs correctly.
Kodiologist
force-pushed
the
hy2py-testing
branch
3 times, most recently
from
83f34b2 to
7f4ce6c
Compare
vodik
approved these changes
Mar 31, 2018
Instead of just checking that hy2py outputs a nonempty string and doesn't crash, we check that a hy2py-generated Python program works the same as the original Hy program. This test suggests my plan to make hy2py output real Python has succeeded, so I updated NEWS accordingly.
Kodiologist
force-pushed
the
hy2py-testing
branch
from
7f4ce6c to
f332ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.