Merged
Conversation
vodik
force-pushed
the
remove-def
branch
2 times, most recently
from
be06209 to
32d7981
Compare
Member
|
I think we should decide what we're going to do with it before removing it; for example, replacing |
Contributor
Author
|
Yup, that's fair, but that should be easy to add on top of this. |
Member
|
That's true, and this alone is more likely to get consensus. So let's go with it. Just update the |
Contributor
Author
|
Done. I'm pretty sure |
Kodiologist
approved these changes
Jan 21, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply removed
defkeyword and replaces it withsetveverywhere. See #1475 and #911.