Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setv always return None #1257

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Make setv always return None #1257

merged 1 commit into from
Mar 24, 2017

Conversation

Kodiologist
Copy link
Member

@Kodiologist Kodiologist commented Mar 23, 2017 •
edited
Loading

Having setv return its lvalue sounds good on paper but leads to problems like the below. This change will also allow me to fix bugs in #1246 regarding when the REPL shows output.

@Kodiologist Kodiologist force-pushed the make-setv-return-none branch from 08f08de to b6a5a0d Compare March 23, 2017 22:06
@Kodiologist Kodiologist force-pushed the make-setv-return-none branch from b6a5a0d to 3af9f46 Compare March 23, 2017 22:12
@Kodiologist Kodiologist requested review from tuturto and gilch March 23, 2017 22:19
@Kodiologist Kodiologist removed the request for review from gilch March 23, 2017 23:59
@tuturto tuturto merged commit ae1dd78 into hylang:master Mar 24, 2017
@Kodiologist Kodiologist deleted the make-setv-return-none branch March 26, 2017 23:34
@refi64 refi64 mentioned this pull request Apr 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuturto tuturto tuturto approved these changes

@refi64 refi64 refi64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Kodiologist @tuturto @refi64