feat(hydro_deploy, hydro_lang): make profiling runnable on macOS #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as the user runs `sudo dtrace` shortly before launching a Hydro deployment with profiling (so that sudo inherits the recent permission grant), things work end-to-end. We don't currently support measuring user vs system time on non-Linux so stub out that logic with dummy values.
Deploying hydroflow with
|
| Latest commit: |
11df1a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c203ba47.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1739.hydroflow.pages.dev |
| { | ||
| println!( | ||
| "{} Total {:.4}%, User {:.4}%, System {:.4}%", | ||
| CPU_USAGE_PREFIX, 100.0, 100.0, 0.0 |
There was a problem hiding this comment.
Seems misleading?? Shouldn't we just print NaN or something?
Comment on lines
-165
to
+167
| let mut command = Command::new("dtrace"); | ||
| let mut command = Command::new("sudo"); | ||
| command | ||
| .arg("dtrace") |
There was a problem hiding this comment.
Isn't it just possible to run hydro_deploy as sudo?
There was a problem hiding this comment.
That unfortunately messes up the target/ directory with a bunch of root-owned files. This restricts root to only launching the binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as the user runs
sudo dtraceshortly before launching a Hydro deployment with profiling (so that sudo inherits the recent permission grant), things work end-to-end. We don't currently support measuring user vs system time on non-Linux so stub out that logic with dummy values.