Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deploy feature to template cargo.toml to fix RA errors #1738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rupert648
Copy link

Rust Analyzer when starting up in the template project shows the following error.

rust-analyzer Flycheck failed: package 'hydro-template' does not contain feature 'deploy'
Error occurred when running: cargo check --workspace --features deploy

Adding the deploy feature to cargo.toml seems to prevent this error from occurring after a clone of the template, without affecting builds.

Rust Analyzer when starting up in the template project shows the following error.
```
rust-analyzer Flycheck failed: package 'hydro-template' does not contain feature 'deploy'
Error occurred when running: cargo check --workspace --features deploy
```
Adding the deploy feature to cargo.toml seems to prevent this error from occurring, without affecting builds.
@shadaj
Copy link
Member

shadaj commented Feb 22, 2025

Thanks for the PR! It's a bit strange that such a warning shows up since "deploy" is only a relevant feature for hydro_lang, might be a bug with the logic in stageleft, so I'll try to do a bit of investigation in case we can find the root cause.

@shadaj
Copy link
Member

shadaj commented Feb 22, 2025

Oh, I wonder if https://github.com/hydro-project/hydro/blob/main/.vscode/settings.json is somehow leaking into your RA config (there we globally enable the "deploy" feature for local development).

@MingweiSamuel MingweiSamuel added the bug Something isn't working label Feb 27, 2025
@MingweiSamuel
Copy link
Member

Having trouble reproducing, @rupert648 how did you create the template project? Different from cargo generate gh:hydro-project/hydro-template?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants