Huntress mods 8 0 #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Westendorf <[email protected]>
We'd like to be able to correlate individual queries to any of the EOF errors we're seeing. This returns the query ID in all of the error responses so that when we see EOF errors, we can see which specific queries they occurred on.
kbennoune
force-pushed
the
huntress_mods_8-0
branch
from
6a012ac to
835ef7c
Compare
We're getting an EOFError thousands of times a day and ClickHouse has asked us to give them query IDs to that they can look into it. I previously put in functionality to add the query ID to the raised error, but the one place I missed is the one place throwing all the errors. This sets a query ID that will be used in the HTTP(S) request and will be in the error message where this is being raised.
…-id-to-error Add query ID to error message
Fix a syntax error I missed because this library supports older versions of Ruby (2.7).
…-id-to-error Fix syntax error due to older Ruby
I called the method passing a Hash at the end, but it was actually a kwarg named settings. This corrects that call.
The bug is that, for some columns with defaults, the value returned from the DB is "true" instead of the actual value present in the DB. The correct value is returned when the record is reloaded.
…for-default-returning-true Add workaround for Clickhouse returning `true` for default values on insert. While the correct default value has never actually been returned from the database, this was silently ignored in Rails 7.x and before. With Rails 8 (specifically rails/rails#53359), the true value starts causing an error for datetime columns (which it should, since true is not valid in such columns).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.