Skip to content

Commit

Permalink
fix rename issues
Browse files Browse the repository at this point in the history
  • Loading branch information
jameswex committed Jun 28, 2019
1 parent f19d52f commit 4caacec
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion facets_dive/components/facets_dive/facets-dive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ Polymer({
this._updateHeight();
},

_updateHeight(this: any, height: number) {
_updateHeight: function(this: any, height: number) {
if (this.height !== null) {
this.style.height =
typeof this.height === 'number' ? this.height + 'px' : this.height;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,11 +231,11 @@ Polymer({
return positionMode === 'scatter';
},

_isKeyNumeric(this: any, key: string): boolean {
_isKeyNumeric: function(this: any, key: string): boolean {
return this.stats && (key in this.stats) && this.stats[key].isNumeric();
},

_isKeyCategorical(this: any, key: string): boolean {
_isKeyCategorical: function(this: any, key: string): boolean {
return this.stats && (key in this.stats) && !this.stats[key].isNumeric();
},

Expand Down Expand Up @@ -273,7 +273,7 @@ Polymer({
/**
* Return whether the chosen field has a usable word tree.
*/
_hasWordTree(this: any, fieldName: string): boolean {
_hasWordTree: function(this: any, fieldName: string): boolean {
const fieldStats: FieldStats = this.stats ? this.stats[fieldName] : null;
return !!fieldStats && !!fieldStats.wordTree &&
fieldStats.wordTree.highestLevel > 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,8 @@ Polymer({
return count;
},
// tslint:disable-next-line:no-any typescript/polymer temporary issue
_updateSelectionVisibility(this: any, selection: utils.FeatureSelection) {
_updateSelectionVisibility: function(
this: any, selection: utils.FeatureSelection) {
if (!this._selectionElem) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Polymer({
_rowHeight: {type: Number, value: 100, readOnly: true},
},
// tslint:disable-next-line:no-any typescript/polymer temporary issue
_handleResize(this: any) {
_handleResize: function(this: any) {
// Iron-lists must be explicitly sized to operate correctly and effiencly,
// per the documentation. But we want an iron-list that is max height 800px
// but can shrink to accomodate feature tables with a small number of
Expand Down Expand Up @@ -155,7 +155,8 @@ Polymer({
}
return dataModel.getFeature(feature.getName()!, dataset.getName()!);
},
_getChartData(dataModel: OverviewDataModel, feature: FeatureNameStatistics):
_getChartData: function(
dataModel: OverviewDataModel, feature: FeatureNameStatistics):
utils.HistogramForDataset[] {
if (!dataModel || !feature) {
return [];
Expand Down

0 comments on commit 4caacec

Please sign in to comment.