Skip to content

Conversation

WuonParticle
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Make fastify logs useful by eliminating ping logs (turn on fastify logs by modify conf/server.yml
  • Some linting changes from extending line width got included.
  • Added logFilenameFormat config value as log files were not creating symlinks for stach traces without the .log extension

Tests performed by the developer:
pnpm clean && pnpm install && pnpm build && pnpm test && pnpm start --dev

Tips for QA testing:

  1. checkout development (e.g. not this branch)
  2. Change conf/server/yml : fastifyLogs to true
  3. run pnpm build
    2 run pnpm start,
  4. Start hbot
  5. See ping logs for / are in gateway console
  6. kill gateway & hbot
  7. checkout this branch
  8. run pnpm build
    2 run pnpm start,
  9. Start hbot,
  10. see ping logs are no longer flooding the console.

@rapcmia rapcmia requested a review from fengtality September 3, 2025 02:34
@fengtality
Copy link
Contributor

merge conflicts need resolution before review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants