-
-
Notifications
You must be signed in to change notification settings - Fork 238
Feat/record and play framework #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Feat/record and play framework #490
Conversation
3cdeed9
to
3105bf2
Compare
672c179
to
6d8b2e3
Compare
cc96cde
to
9bd329a
Compare
Separated the "Play" tests from the primary test suite today with 9bd329a as LLM agents were running the unit test suite with -u to force snapshots to avoid having to actually debug issues. Also clarified everywhere "Record" and "Play" Tests rather than saying unit. |
I recommend doing a squash merge when eventually merging this as 42 commits is pretty outrageous for the functionality being added. However, I think keeping the git history in the PR is important for posterity and to understand why some design decisions were made. |
… responses on same dependency.
…lly. 400 makes more sense for invalid input anyway.
clarify that setup file is run per suite rather than once globally.
…re okay to ignore during playback.
…chains. rename useDep2 to useUnmappedDep. Also made complimentary useUnmappedMethodMocked and useUnmappedMethodRecorder to produce clean test pass output.
…large number of parameters.
… clarify explicitly that the output varies between the two.
… names with gemini-2.5-pro.
…rd-and-play files under test/ . Prevent snapshot updates during "Play" tests.
9bd329a
to
f114828
Compare
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
New Features
Bug Fixes
Chores
Documentation
Tests performed by the developer:
pnpm test-record
(changes files intentionally)pnpm test rnp
Tips for QA testing:
pnpm test
- verify that all tests passpnpm test rnp
- verify that only tests with rnp in the name are run and passpnpm test-play
- verify that only play tests are run and passpnpm test-record
- verify that rnpExample mock files and snapshot file changes changepnpm test-play
- verify that only rnp tests are run and passpnpm test-play
- verify that rnpExample play tests relying on mocks failpnpm test-play
- verify that tests pass