Feat/cardano #484
Feat/cardano #484
Conversation
|
Note that Gateway is in the middle of a big refactor outlined in: #467. v2.8 is slated for release in August. There are more changes coming wrt to the Hummingbot-Gateway interface, esp for sending and confirming transactions. As this interface needs to be designed to fit Ethereum and Solana chains and wallets, we will defer reviewing and merging PRs for non EVM and non SVM chain architectures until a later date, yet to be announced. In the meantime, I encourage you to keep your fork up to date with the changes in v2.8 and subsequent releases. |
|
Thanks for the contribution! If you resolve the conflicts (likely related to final v2.8 changes), I will review and test. |
…r sundaeswap also written test cases for cardano chain and minswap and sundaeswap
…for cardano support and fixed tokens routes for cardano and added three network mainnet, preprod and preview for tokens
Aiquant1
force-pushed
the
feat/cardano
branch
from
7bf2ddc to
2007df0
Compare
- Move Cardano.getInstance() from route registration to request handlers - Replace dynamic wallet address examples with static placeholders - Prevent server startup crashes caused by premature blockchain connection - Align Cardano initialization pattern with other chain implementations fixed wallet, chains, pools route for cardano
Aiquant1
force-pushed
the
feat/cardano
branch
from
261e9e7 to
cf8a9ae
Compare
- Implement liquidity operations (add/remove/quote) for both DEXs - Add pool info and swap quote endpoints - Fix token address normalization for Cardano native assets - Support multiple token address formats (dot notation and concatenated) - Add Cardano wallet integration and validation utilities
HI @fengtality, we have resolved the conflict, code is ready to merge. |
Aiquant1
force-pushed
the
feat/cardano
branch
from
1da3464 to
47cc49e
Compare
|
Given that there's custom libs being imported, we need to verify that the DEXs and Cardano themselves are supportive of this connector. Otherwise, there's too many security risks for us to import these libs. Please have the folks behind this PR reach out to me on the Hummingbot Discord or Twitter @fengtality. |
Blockfrost is not a custom lib it is a of chain node connector for Cardano, majorly used for on chain operations. As this is a dex we can interact directly with the dexs and make trades there, If the issue with the libs is there let's have a discission on discord regarding this thank you for your id, I will reach out. As we are developing the libs and keeping it up to date with core libs like sudeswap-core and minswap-sdk and lucid-cardano. Blockfrost is a Cardano blockchain library to connect to an remote node provided as a service, it is actively maintained by other developer in Cardano and is one of the core libraries in off chain to on chain connectors. |
…eSwap - Fix base/quote token logic to match industry standards - Fix asset mappings for any pool structure - Fix amount parameter to use base token units - Update all DEX routes (swap, liquidity, execute)
3 participants
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Adding a new chain for the Cardano Blockchain along with Minswap & Sundaeswap dex.
Allow users to trade and add/remove liquidity on AMM on these Cardano Dexs.
Tests performed by the developer:
Manual testing as well as Unit testing.
path for test cases: test/chains/cardano
path for AMM tests Minswap: test/connectors/minswap
path for AMM tests Sundaeswap: test/connectors/sundaeswap
Tips for QA testing:
Can execute swap, add and remove liquidity in both Cardano Dex.