Added WebSocketNonNegotiableExtensionBuilder #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
Nov 18, 2024
|
|
||
| let _build: @Sendable () -> Extension | ||
|
|
||
| init(_ build: @escaping @Sendable () -> Extension) { |
There was a problem hiding this comment.
Does this need to be public? Maybe people want to use non-negotiable extensions mixed with negotiable extensions
There was a problem hiding this comment.
You can mix non-negotiable extensions with negotiable already eg
extensions: [
.nonNegotiatedExtension { MyExtension() },
.perMessageDeflate()
]There was a problem hiding this comment.
Ah I see, I misunderstood how this was handled internally
Joannis
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WebSocket extensions you want to apply without requiring negotiation with the other side.
Also split extension code up a bit so it is easier to read.