2.x.x Template struct #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
force-pushed
the
template-struct
branch
from
1f20d25 to
c2c77d2
Compare
Joannis
reviewed
Jan 31, 2024
Comment on lines
43
to
44
| - 'swift:5.7' | ||
| - 'swift:5.8' |
There was a problem hiding this comment.
Still planning on supporting these?
There was a problem hiding this comment.
No harm, doing that here. I've use this outside of server development so its minimum supported swift version isn't linked to the minimum version for HB
Joannis
reviewed
Jan 31, 2024
Joannis
reviewed
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #22 +/- ##
========================================
Coverage ? 91.27%
========================================
Files ? 16
Lines ? 1032
Branches ? 0
========================================
Hits ? 942
Misses ? 90
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Joannis
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
HBMustacheTemplateSendable I have had to change the structure of things slightly. These are breaking changes.HBMustacheTemplateis now a structHBMustacheLibraryis a now a structHBMustacheContextwhen rendering the template. For partials to work the template needs to be rendered viaHBMustacheLibrary.render.I didn't think we'd need a v2.0 of hummingbird-mustache but it looks like we will