2.x.x todos tutorial #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise variable rename, comment updates
Joannis
requested changes
Jan 16, 2024
| @@ -0,0 +1,14 @@ | |||
| import Hummingbird | |||
| @_spi(ConnectionPool) import PostgresNIO | |||
There was a problem hiding this comment.
I like their connection pool, like everyone, but @_spi in a tutorial doesn't feel right
There was a problem hiding this comment.
Yes I know. But I don't have an alternative unless I use the Vapor alternative. Remember this is still alpha software.
There was a problem hiding this comment.
I'll mention something in the tutorial text for the moment and hope Fabian removes this eventually
Joannis
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the example used in the todos tutorial