Server sent events #134
Merged
Server sent events #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-fowler
commented
Dec 9, 2024
server-sent-events/Package.swift
Outdated
| dependencies: [ | ||
| .package( | ||
| url: "https://github.com/hummingbird-project/hummingbird.git", | ||
| branch: "cancel-on-inbound-close2" |
There was a problem hiding this comment.
Remember to revert once cancelOnInboundClose changes are merged
|
@adam-fowler why do you need to rely on |
For some reason I thought there had been no release made. I can see I was wrong. I can fix that |
|
Just two changes needed (6.0 and the change to a release once that's ready). You can merge after that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example demonstrating server sent events.