Get rid of LoginCache in favour of a stored property for an identity #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
changed the title
adam-fowler
requested changes
Sep 29, 2024
adam-fowler
requested changes
Sep 29, 2024
Sources/HummingbirdAuth/Authenticator/ClosureAuthenticator.swift
Outdated
Show resolved
Hide resolved
Sources/HummingbirdAuth/Middleware/IsAuthenticatedMiddleware.swift
Outdated
Show resolved
Hide resolved
adam-fowler
previously approved these changes
Sep 30, 2024
|
Right, I changed 1 signature after running the tests :| |
|
Swift format? |
|
There also a number of documentation updates to make. |
|
Isn't the documentation part of a different package? |
|
The errors are most likely in the function comment headers. If you check the output you can see the issues. |
adam-fowler
approved these changes
Sep 30, 2024
adam-fowler
added a commit
that referenced
this pull request
Oct 14, 2024
* SessionMiddleware storing session in context * sessions should be a let * Fix up BasicSessionRequestContext * Add expiration date * Add SessionMiddleware.init that takes persist storage directly * Comments * Make SessionContext.init public * fixup documentation * More comments * Delete session and updating tests * Shouldn't be required to set an expiresIn value when updating session * Make SessionStorage generic over the session type * Fix the unit tests * Get rid of LoginCache in favour of a stored property for an identity (#67) * Get rid of LoginCache in favour of a stored property for an identity that's optional * Remove the Authenticatable protocol * Simplify usage of generics constraints * Fix the use of the IsAuthenticatedMiddleware init * Formatting * Clean up docs * A bit lighter on nested generics by moving them to the middleware --------- Co-authored-by: Joannis Orlandos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…that's optional