Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log playwright browser download progress on stderr #682

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: log playwright browser download progress on stderr #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,19 @@ export async function getPw(browserName) {
const api = await import('playwright-core')
const browser = registry.findExecutable(browserName)

await registry.install([browser])
// playwright will log browser download progress to stdout, temporarily
// redirect the output to stderr
const log = console.log
const info = console.info

try {
console.log = console.error
console.info = console.error
await registry.install([browser])
} finally {
console.log = log
console.info = info
}

return api[browserName]
}
Expand Down