refactor to rewrite shard header with footer_len set to 0 #551
+47
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanses
reviewed
Nov 3, 2025
seanses
reviewed
Nov 4, 2025
hoytak
approved these changes
Nov 4, 2025
|
P.S. Also tested with this version that uploads work and CAS does accept this |
seanses
reviewed
Nov 4, 2025
|
|
||
| use super::*; | ||
|
|
||
| fn test_read_shard_to_bytes_remove_footer() -> Result<()> { |
There was a problem hiding this comment.
Missing the #[test] attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #547
When xet-core uploads the shard the header field where the footer length is specified is set to 200 where it should be 0 according to the specification.
Note: this value is ignored by the server today, but ideally we would set this right since it can be useful to know if there is a footer on the shard when reading the shard as a whole in a non-streaming fashion.