-
Notifications
You must be signed in to change notification settings - Fork 31.1k
handle inputs from Siglip/Siglip2 non-automapped encoder layers #41930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
ca68be8
76a14c7
4f93734
082dcf2
fe7c922
5aa7610
807983c
448dd63
91d34b0
40a9dc8
f54d0db
3ee3c56
c4400cb
92eeed6
b3db730
b7fec03
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -836,7 +836,7 @@ def wrapper(self, *args, **kwargs): | |||
| all_args[k] = v | ||||
|
|
||||
| # _can_record_outputs is None by default | ||||
| capture_flags = _CAN_RECORD_REGISTRY.get(str(self.__class__)) or {} # there is a weak ref for executorch | ||||
| capture_flags = _CAN_RECORD_REGISTRY.get(str(self.__class__)) or getattr(self, "_can_record_outputs", {}) | ||||
|
||||
| _CAN_RECORD_REGISTRY[str(self.__class__)] = self._can_record_outputs # added for executorch support only |
And I honestly don't wanna risk breaking executorch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah the latter reason is compelling 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Ig this was already inherited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh, interesting. yes it should have been, entirely unrelated to this lol