Skip to content

[Attention] Small fix on output attentions #38948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

vasqu
Copy link
Contributor

@vasqu vasqu commented Jun 20, 2025

Currently, anytime a user sets output_attentions in the config it errors out when not using eager. However, it should only error if the value is actually invalid (ie True).

cc @ArthurZucker

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! indeed

@ArthurZucker ArthurZucker merged commit 23c89a6 into main Jun 24, 2025
21 checks passed
@ArthurZucker ArthurZucker deleted the vas-output-attn-config-fix branch June 24, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants