-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Support pydantic schemas in tools #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aymeric-roucher
wants to merge
20
commits into
main
Choose a base branch
from
feature/pydantic-schema-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,023
−35
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
89f8e3a
feat: add Pydantic model support for tool argument validation and sch…
chitralputhran 1871b25
feat(tests): add Pydantic integration tests for tool argument validation
chitralputhran b2b1097
Simplify
aymeric-roucher f9207ba
Rmove dict conversion to pydantic
aymeric-roucher e71ce77
Pass tests
aymeric-roucher b89ba9b
Merge branch 'main' into feature/pydantic-schema-support
aymeric-roucher 55ea6d8
Pass tests
aymeric-roucher 29d31c7
Validate and test pydantic models on Tool subclass
aymeric-roucher 4d96f38
Simplify structure
aymeric-roucher ce7a705
Rever comment change
aymeric-roucher f788e99
Require a description in pydantic basemodels
aymeric-roucher 02881ee
Clarify type of inputs to avoid linting errors
aymeric-roucher bf01ab6
Fix some linting errors
aymeric-roucher 7485f0d
Fix multiagent test
aymeric-roucher f5ed4da
Format
aymeric-roucher 5ead41c
Simplify value conversion function
aymeric-roucher 75e9b67
Merge branch 'main' into feature/pydantic-schema-support
aymeric-roucher 2f06943
Fix typing.Any error
aymeric-roucher 5d1afe4
Revert usage of get_type_hints
aymeric-roucher fe53e82
Revert previous simplification
aymeric-roucher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertvillanova a big part of the logic in there is to handle our "nullable" parameter with Pydantic models that follow a different json schema spec.
Maybe it would be wise in a follow-up PR to handle json schemas directly rather than converting their logic to our nullable fomat
Handling json shcemas directly could use either of the solutions below:
Solution 1:
Just add a completely new validation logic, with a tool.input_schema parameter that follows the pydantic schema : each tool init could either (exclusive OR) use tool.inputs or tool.input_schema, depending on what was use for initialization.
Then after some time, tool.inputs could be deprecated to only follow the new version.
Solution 2:
Let tool.inputs be either our legacy way of describing inputs, or a json schema. This is detected dynamically, then either logic is used for validation.