Skip to content

Fix sft example#220

Open
tarbaig wants to merge 2 commits intohuggingface:mainfrom
tarbaig:fix_sft_example
Open

Fix sft example#220
tarbaig wants to merge 2 commits intohuggingface:mainfrom
tarbaig:fix_sft_example

Conversation

@tarbaig
Copy link

@tarbaig tarbaig commented Jun 15, 2025

There are multiple small bugs due to changes in function signatures in sft_finetuning_example.ipynb.

In addition the notebook needs wandDB integration in its current form, without any added value.

This PR changes the names of the keyword arguments to fit the current call signatures of SFTConfig and SFTTrainer and disables wandDB.

@tarbaig
Copy link
Author

tarbaig commented Jun 15, 2025

This would close #218 and #219

@ly61zybaydl
Copy link

In your sft_finetuninbg_example.ipynb,you need to remove "#" in line 2 to install all packages in requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants