Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290
Problem
link --create-prprinted "PR creation not yet implemented" and then calledupload_filewithoutcreate_pr, so the README change landed on main.Change
create_prthrough toHfApi.upload_fileand keep the returnedCommitInfo.pr_urlto the JSON output(
main()prints that dict). Direct-commit output is unchanged.Testing
scripts/test_paper_manager.py(unittest, mockedHfApi, no network or token).create_pr=Trueforwards the flag and reports the PR URL. It fails without thefix and passes with it.
before and after.
test_build_skill_distribution.pystill passes.Not addressed
--create-pr, each paper opens its own PR against main,so they may conflict once one is merged.
That already happens in direct mode.
test_build_skill_distribution.py.Happy to wire it in if you want.
Thanks @JacobTRND for the report and diagnosis. I used Claude Code to help
investigate and draft; I reviewed the diff and ran the tests myself.